More empty string environment variable handling#103
Merged
ralphlange merged 1 commit intoepics-base:masterfrom Aug 28, 2025
Merged
More empty string environment variable handling#103ralphlange merged 1 commit intoepics-base:masterfrom
ralphlange merged 1 commit intoepics-base:masterfrom
Conversation
Enforce equivalence between unset and set to empty string for some more environment variables. Also, stricter validation of $WINE
Member
Author
|
Motivated by my wanting to override |
Contributor
|
LGTM. Thanks! |
Contributor
|
Just curious: the include mechanism didn't do that properly? |
Member
Author
|
I find it cumbersome to carry around a .set file for each special job. My preference is to do these overrides from the GHA matrix. jobs:
native:
env:
BASE_REPOOWNER: ${{ matrix.owner }}
strategy:
fail-fast: false
matrix:
include:
- name: regular
- name: special
owner: voldemort |
Contributor
|
Ah, understood. Not setting it would still overwrite. |
Contributor
|
BTW. I finally fixed the ci-scripts CI - stay tuned. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enforce equivalence between unset and set to empty string for some more environment variables.
Also, stricter validation of $WINE